docs: fix examples in website_docs/instrumentation.md

[svrnm]

Like open-telemetry/opentelemetry-js-api#116 this fixes the examples in the website docs to work properly again.

[codecov]

Codecov Report

Merging #2412 (eb6a770) into main (5b4ca1c) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2412      +/-   ##
==========================================
+ Coverage   92.49%   92.62%   +0.12%     
==========================================
  Files         134      137       +3     
  Lines        4850     4975     +125     
  Branches     1027     1048      +21     
==========================================
+ Hits         4486     4608     +122     
- Misses        364      367       +3     

Impacted Files	Coverage Δ
...emetry-api-metrics/src/platform/node/globalThis.ts	0.00% <0.00%> (-100.00%)	⬇️
...sync-hooks/src/AbstractAsyncHooksContextManager.ts	97.01% <0.00%> (ø)
...async-hooks/src/AsyncLocalStorageContextManager.ts	100.00% <0.00%> (ø)
...ontext-async-hooks/src/AsyncHooksContextManager.ts	100.00% <0.00%> (ø)

[svrnm]

This PR now also contains an update for the node.js example to use the node-sdk

[svrnm]

A few open questions on that:

• I didn't get it to work to use the NodeSDK for metrics. I guess there's still a few pieces missing?
• The sdk.start() is in the required tracing.js file. Would it be better to add the code into the app.js and wait for the sdk.start() to fulfill before the express server is started?

[dyladan]

This looks way easier for a newcomer to follow thanks :)

[dyladan]

A few open questions on that:

• I didn't get it to work to use the NodeSDK for metrics. I guess there's still a few pieces missing?
• The sdk.start() is in the required tracing.js file. Would it be better to add the code into the app.js and wait for the sdk.start() to fulfill before the express server is started?

I really want to make the sdk.start() be sync, but that requires removing the async nature of resource detection. I really don't know what to do there and the spec has been unhelpful each time i've tried to tackle it there.

[jasonkuhrt]

Nice! This lines up much more closely with what I've ended up having to do so far 🙏

[vmarchaud]

I didn't get it to work to use the NodeSDK for metrics. I guess there's still a few pieces missing?

The current SDK is heavily behind the spec, speaking of this @dyladan do you have any news of the person of Dynatrace that was allocated time to work on metrics ?