-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk-trace-web): fix lint warnings #2451
Merged
vmarchaud
merged 10 commits into
open-telemetry:main
from
alisabzevari:lint-warnings-sdk-trace-web
Nov 17, 2021
Merged
chore(sdk-trace-web): fix lint warnings #2451
vmarchaud
merged 10 commits into
open-telemetry:main
from
alisabzevari:lint-warnings-sdk-trace-web
Nov 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisabzevari
commented
Sep 3, 2021
Codecov Report
@@ Coverage Diff @@
## main #2451 +/- ##
==========================================
- Coverage 93.26% 92.88% -0.38%
==========================================
Files 115 105 -10
Lines 4645 3978 -667
Branches 1036 901 -135
==========================================
- Hits 4332 3695 -637
+ Misses 313 283 -30 |
rauno56
approved these changes
Sep 6, 2021
obecny
reviewed
Sep 8, 2021
…/opentelemetry-js into lint-warnings-sdk-trace-web
dyladan
approved these changes
Nov 12, 2021
@dyladan It appears the cla is broken, do you know how to fix this ? |
/easycla |
@vmarchaud ^ like that |
vmarchaud
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1093,
Which problem is this PR solving?
sdk-trace-web
package.Short description of the changes