-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prefer globalThis instead of window to support webworkers #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no `window` in either WebWorkers and ServiceWorkers.
Codecov Report
@@ Coverage Diff @@
## main #2465 +/- ##
==========================================
+ Coverage 92.69% 92.93% +0.24%
==========================================
Files 129 135 +6
Lines 4503 4941 +438
Branches 973 1059 +86
==========================================
+ Hits 4174 4592 +418
- Misses 329 349 +20 |
legendecas
force-pushed
the
fix/core-window
branch
from
September 9, 2021 09:20
b9958b4
to
ef8e0ca
Compare
Flarna
approved these changes
Sep 9, 2021
obecny
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
packages/opentelemetry-core/test/platform/browser/environment.test.ts
Outdated
Show resolved
Hide resolved
johnbley
approved these changes
Sep 10, 2021
…test.ts Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
MSNev
reviewed
Sep 13, 2021
packages/opentelemetry-core/src/platform/browser/environment.ts
Outdated
Show resolved
Hide resolved
vmarchaud
approved these changes
Sep 14, 2021
rauno56
approved these changes
Oct 14, 2021
This was referenced Nov 9, 2021
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
window
in either WebWorkers and ServiceWorkers.Short description of the changes
globalThis
thanwindow
ingetEnv
.