-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new merge function #2484
feat: new merge function #2484
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2484 +/- ##
==========================================
- Coverage 93.23% 93.07% -0.17%
==========================================
Files 137 139 +2
Lines 5044 5172 +128
Branches 1067 1110 +43
==========================================
+ Hits 4703 4814 +111
- Misses 341 358 +17
|
@@ -71,6 +71,7 @@ | |||
"karma-mocha": "2.0.1", | |||
"karma-spec-reporter": "0.0.32", | |||
"karma-webpack": "4.0.2", | |||
"lerna": "3.22.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does lerna need to be in dev deps ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
he doesn't want to have to have it installed globally. The npm scripts call lerna so if you have it in dev deps they find it correctly. If not, it looks for global.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but i meant why does it need to be commited ? We expect it to be available globally right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you dont have lerna locally you cant compile it. Not mentioning that the lerna we are using should be compatible with the one that is in the project. This is also missing in other packages which should be added. We should not expect user to have lerna installed globally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then do we need to add it to all other packages ? I would prefer to do this in another PR
Looks good to me once the comment valentin made is resolved. Thanks for adding comprehensive tests. |
My comment about lerna still stand i would prefer doing it in another PR but its not blocking |
Seriously???, it stucked 20 days in review because of this comment ....... Without lerna you can't compile it separately it was broken during big refactoring, not even mentioning that now all packages cannot be compiled separately if you don't have lerna installed globally. |
You don't need to do passive/aggresive for a review comment, i asked a question and you didn't answer (i guess because of your holiday and thats fine) so don't blame me please.
I understood this, i just stated that it wasn't linked to the original PR so it would make more sense to make a PR to add lerna to all packages since the problem will be the same with others. |
Which problem is this PR solving?