Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove usage of serviceName property in tests for otel collector #2491

Merged

Conversation

mustafain117
Copy link
Contributor

@mustafain117 mustafain117 commented Sep 22, 2021

Which problem is this PR solving?

Short description of the changes

  • Two test cases in package opentelemetry-exporter-otlp-http are using the serviceName property for configuration of OTLPTraceExporter and OTPLMetricExporter.serviceName is not a valid property of the config object (OTLPExporterNodeConfigBase), this PR removes the usage of this property in the test cases.

@mustafain117 mustafain117 requested a review from a team September 22, 2021 21:02
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 22, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2491 (68aa0c6) into main (6a78db1) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2491      +/-   ##
==========================================
- Coverage   93.22%   93.20%   -0.02%     
==========================================
  Files         137      137              
  Lines        5017     5017              
  Branches     1060     1060              
==========================================
- Hits         4677     4676       -1     
- Misses        340      341       +1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@dyladan
Copy link
Member

dyladan commented Sep 22, 2021

Please sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example and tests for otel collector exporter is not updated still uses serviceName
5 participants