-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(exporter-zipkin): correct status tags names #2519
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2519 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 137 137
Lines 5042 5043 +1
Branches 1066 1067 +1
=======================================
+ Hits 4701 4702 +1
Misses 341 341
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md suggests that for a status of ERROR
, the error messages should be in an error
tag/attribute. It specifically calls out that it overrides the generic status mapping rule. Would like to see a fix for that and a test covering the error case. See https://github.com/open-telemetry/opentelemetry-swift/pull/232/files for a recent swift change I did that was similar.
@johnbley Updated to be based on the zipkin specific doc. Should be already covered by Seems like unrelated rounding fail in test? |
Most likely unrelated. I'm running again to see if it is consistent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks!
Which problem is this PR solving?
As per OpenTelemetry to Zipkin Transformation spec:
Short description of the changes
Corrected the tag names (
ot.
->otel.
), check for unset statusFor reference: zipkin exporter in otel-java