Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-metrics-base): remove metric kind BATCH_OBSERVER #2540

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Oct 18, 2021

Which problem is this PR solving?

BatchObserver is no longer a metric since #1709. MetricKind.BATCH_OBSERVER should be removed.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

There are no tests on enum keys.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

BATCH_OBSERVER is no longer a metric.
@legendecas legendecas requested a review from a team October 18, 2021 06:03
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #2540 (95e963a) into main (3045eba) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 95e963a differs from pull request most recent head 6132c08. Consider uploading reports for the commit 6132c08 to get more accurate results

@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
- Coverage   93.05%   93.05%   -0.01%     
==========================================
  Files         139      139              
  Lines        5172     5171       -1     
  Branches     1110     1110              
==========================================
- Hits         4813     4812       -1     
  Misses        359      359              
Impacted Files Coverage Δ
...opentelemetry-sdk-metrics-base/src/export/types.ts 100.00% <0.00%> (ø)

@obecny obecny added enhancement New feature or request breaking and removed enhancement New feature or request labels Oct 21, 2021
@obecny obecny merged commit 9df2132 into open-telemetry:main Oct 21, 2021
@legendecas legendecas deleted the metrics-ff/batch-observer-kind branch October 22, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants