feat: spec compliant metric creation and sync instruments #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2588 +/- ##
==========================================
- Coverage 93.10% 93.10% -0.01%
==========================================
Files 123 123
Lines 4759 4755 -4
Branches 1061 1060 -1
==========================================
- Hits 4431 4427 -4
Misses 328 328
|
legendecas
reviewed
Nov 24, 2021
dyladan
force-pushed
the
sync-metric-options
branch
from
4de7823
to
5212d9d
Compare
legendecas
approved these changes
Dec 1, 2021
vmarchaud
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
MetricOptionsto remove unspecified optionsUpdate metric creation methods to use new type
Add optional context to synchronous instruments
Fixes [api-metrics]: Create or verify compliance of Counter #2548
Fixes [api-metrics]: Create or verify compliance of UpDownCounter #2549
Fixes [api-metrics]: Create or verify compliance of Histogram #2552