-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Document the HrTime format #2604
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
+ Coverage 93.00% 93.02% +0.01%
==========================================
Files 138 138
Lines 5092 5092
Branches 1095 1095
==========================================
+ Hits 4736 4737 +1
+ Misses 356 355 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool to have this doc also in API (e.g. https://github.com/open-telemetry/opentelemetry-js-api/blob/a752e7f814e7b335e50705d281cb2c6e1bd38a35/src/common/Time.ts#L16)
@JamesJHPark you mind documenting the type there also? |
Yes, definitely! I will document and update it in opentelemetry-js-api. |
I cannot merge branches that are out of date with the main branch. Please update this branch and I will merge it |
Which problem is this PR solving?
This PR is to address and document the HrTime format,
HrTime = [number, number]
, to specify the representation of the first and second number.Fixes #2578
Short description of the changes
This PR has documented the
HrTime
format.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A
Checklist: