chore: rename metrics packages to prevent lerna linking #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2629 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 115 115
Lines 4645 4645
Branches 1036 1036
=======================================
Hits 4332 4332
Misses 313 313 |
legendecas
approved these changes
Nov 18, 2021
vmarchaud
approved these changes
Nov 19, 2021
dyladan
changed the title
|
@vmarchaud @legendecas i ended up having to change the name instead of the version to get lerna to be happy and the tests to pass. Also had to temporarily move the metrics API to "real" dependencies for the same reason. Apparently the lerna cross-linking in node 16 for peer dependencies works slightly differently. |
This was referenced Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue where the WIP metrics API and SDK cause problems with existing packages by giving them a version number that does not match the dependencies of the existing packages. This means the released 0.27.0 versions will be used when bootstrapping those packages.