Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-metrics): remove observable types #2687

Merged
merged 5 commits into from
Dec 28, 2021

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Removes the redundant type definition of observables, since we didn't have any API for a single observable instance yet.

Fixes #2550
Fixes #2551
Fixes #2553

Short description of the changes

  • Add type ObservableCallback to reduce the duplication of the definition of the callback.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #2687 (fe4c19e) into main (0e9f8af) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2687      +/-   ##
==========================================
+ Coverage   92.52%   92.57%   +0.04%     
==========================================
  Files         151      151              
  Lines        5283     5276       -7     
  Branches     1116     1116              
==========================================
- Hits         4888     4884       -4     
+ Misses        395      392       -3     
Impacted Files Coverage Δ
...ages/opentelemetry-api-metrics/src/types/Metric.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-api-metrics/src/NoopMeter.ts 72.72% <0.00%> (+3.76%) ⬆️

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the name if you are. We can change it in a follow-up if we need

@vmarchaud vmarchaud added the enhancement New feature or request label Dec 28, 2021
@vmarchaud vmarchaud merged commit eba315b into open-telemetry:main Dec 28, 2021
@legendecas legendecas deleted the metrics-ff/observables branch December 29, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants