Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api-metrics): add notes on ObservableResult.observe #2712

Merged

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Add notes on ObservableResult.observe that SDK may choose to pick the last measurement with same attributes values or drop the entire ObservableResult, according to the spec.

Type of change

  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Documentation has been updated

@legendecas legendecas added the document Documentation-related label Jan 12, 2022
@legendecas legendecas requested a review from a team January 12, 2022 03:09
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #2712 (46ac39a) into main (1577f35) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2712   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files         157      157           
  Lines        5432     5432           
  Branches     1141     1141           
=======================================
  Hits         5064     5064           
  Misses        368      368           

@legendecas legendecas merged commit 8bda25c into open-telemetry:main Jan 19, 2022
@legendecas legendecas deleted the metrics-ff/observable-result-doc branch January 19, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants