Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update actions/checkout to v2 #2715

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Fixes open-telemetry/opentelemetry-js-api#144

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #2715 (b7bbe21) into main (04f9edd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2715   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         158      158           
  Lines        5436     5436           
  Branches     1141     1141           
=======================================
  Hits         5068     5068           
  Misses        368      368           

@legendecas legendecas marked this pull request as draft January 13, 2022 10:22
@@ -128,14 +128,14 @@ jobs:
browser-tests-experimental:
runs-on: ubuntu-latest
container:
image: circleci/node:14-browsers
image: circleci/node:16-browsers
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from circleci/node:16 the base image uses Debian 10, the stable git version in the registry is v2.20 which met the bar of actions/checkout@v2 (minimum v2.18).

@legendecas legendecas marked this pull request as ready for review January 13, 2022 11:22
@legendecas legendecas requested a review from a team January 25, 2022 17:16
@legendecas legendecas merged commit 63cff1c into open-telemetry:main Jan 26, 2022
@legendecas legendecas deleted the actions branch January 26, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Workflow test.yaml is using vulnerable action actions/checkout
3 participants