feat(views): handle view conflicts. #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2734 +/- ##
==========================================
+ Coverage 93.41% 93.48% +0.06%
==========================================
Files 160 163 +3
Lines 5467 5541 +74
Branches 1149 1166 +17
==========================================
+ Hits 5107 5180 +73
- Misses 360 361 +1
|
|
Link here for visibility: open-telemetry/opentelemetry-specification#2226 |
legendecas
reviewed
Jan 25, 2022
There was a problem hiding this comment.
Great works 👍 ! I'd like to wait for open-telemetry/opentelemetry-specification#2270 to land since this would really depend on lots of statements in that spec change.
experimental/packages/opentelemetry-sdk-metrics-base/src/state/MetricStorageRegistry.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/InstrumentDescriptor.ts
Outdated
Show resolved
Hide resolved
|
|
||
| export function getDescriptorIncompatibilityDetails(existing: InstrumentDescriptor, otherDescriptor: InstrumentDescriptor) { | ||
| let incompatibility = ''; | ||
| if (existing.description !== otherDescriptor.description) { |
|
@pichlermarc the spec team asked language sdks to prototype the changes proposed at open-telemetry/opentelemetry-specification#2317, would you mind making the changes? |
|
@legendecas yes, I will pick up work on this :) |
pichlermarc
force-pushed
the
handle-view-conflicts
branch
from
acdd6de
to
9300f52
Compare
6 tasks
legendecas
reviewed
Mar 2, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/state/MetricStorageRegistry.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/state/MetricStorageRegistry.ts
Outdated
Show resolved
Hide resolved
pichlermarc
force-pushed
the
handle-view-conflicts
branch
from
79282df
to
cf680f6
Compare
legendecas
approved these changes
Mar 3, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/state/MetricStorageRegistry.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/src/state/MetricStorageRegistry.ts
Outdated
Show resolved
Hide resolved
dyladan
approved these changes
Mar 4, 2022
|
@pichlermarc it seems like I cannot edit this PR (merge the base branch into this PR). Would you mind updating the PR with the latest base branch so that we could merge this one? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR is part of the work on #2592 and adds a
MetricStorageRegistry, as well as logic inMeterto handle conflicts with view names that are used more than once perMeter.Currently waiting for open-telemetry/opentelemetry-specification#2317 to be merged.
Type of change
How Has This Been Tested?
Checklist: