feat(sdk-metrics-base): add ValueType support for sync instruments #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
metrics-ff/value-type-sync
branch
from
3530774
to
2e9dda7
Compare
Codecov Report
@@ Coverage Diff @@
## main #2776 +/- ##
=======================================
Coverage 93.42% 93.43%
=======================================
Files 159 159
Lines 5448 5452 +4
Branches 1144 1145 +1
=======================================
+ Hits 5090 5094 +4
Misses 358 358
|
legendecas
force-pushed
the
metrics-ff/value-type-sync
branch
from
2e9dda7
to
b4b2b0c
Compare
dyladan
approved these changes
Feb 10, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/Instruments.ts
Outdated
Show resolved
Hide resolved
| import { InstrumentDescriptor } from './InstrumentDescriptor'; | ||
| import { WritableMetricStorage } from './state/WritableMetricStorage'; | ||
|
|
||
| export class SyncInstrument { | ||
| constructor(private _writableMetricStorage: WritableMetricStorage, private _descriptor: InstrumentDescriptor) { } | ||
| private _valueType: ValueType; |
There was a problem hiding this comment.
Why have a separate private property when it can be accessed by the private descriptor already?
There was a problem hiding this comment.
I was thinking of reducing the property lookups in the path of counter.add. It is probably trivial, never mind. Updated.
vmarchaud
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Trunc floating-point values if the ValueType is INT for synchronous instruments.
Type of change
How Has This Been Tested?
Checklist: