-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): use 1.x trace otlp http exporter #2788
fix(deps): use 1.x trace otlp http exporter #2788
Conversation
Is this maybe the reason for the problems we saw after updating SDK to use API 1.1? see #2737 (comment)? |
Yes it is likely to be related |
Unless we publish those first, everything brakes outside of the lerna-linked repo. Current latest for |
So i guess i'll hold off on the examples for now but still update the linked packages? |
There's no reason I know of to hold off publishing the exporter 1.0's. I think that should be done asap. Even if we did change only the linked packages the npm installs would still break after we publish the packages that depend on unpublished exporter versions. |
Codecov Report
@@ Coverage Diff @@
## main #2788 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 159 159
Lines 5450 5450
Branches 1145 1145
=======================================
Hits 5091 5091
Misses 359 359
|
Ah yes they should have been released immediately after #2626. Since their versions are already bumped, this just requires a manual publish step. I'll create an issue for this to get maintainer thumbs up because no PR will be needed. |
This PR still should merge before we release them because if not we will have released OTLP exporters depending on the old 0.27 versions in production which is not good. |
@rauno56 actually its worse than I thought here. Because the 1.0 of the exporters (unreleased) introduces a breaking change, the exporters that depend on them are failing to build here when they are linked back together by lerna. The only reason they build successfully now is that they depend on outdated versions which have not removed the breaking property We have 2 options
|
/cc @legendecas @rauno56 @vmarchaud for the above comment |
I vote for (2). |
I'd find (2) would be more intuitive to OTLPExporterBase implementations. TBH, prevent from sending new data on export when already shutdown should be handled well in OTLPExporterBase already and we don't have to repeat everywhere for it. |
I agree for 2) too, sorry for not seeing this before :/ |
Lint failure is caused by an error with the badge links again |
@dyladan it seems like it is a network jittering. Retried and it is passing. |
Some packages incorrectly depend on the unstable otlp http trace exporter