feat(trace-otlp-http-exporter): add compression env vars #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2796 +/- ##
=======================================
Coverage 93.39% 93.39%
=======================================
Files 159 159
Lines 5450 5450
Branches 1145 1145
=======================================
Hits 5090 5090
Misses 360 360
|
vmarchaud
reviewed
Feb 19, 2022
packages/exporter-trace-otlp-http/src/platform/node/OTLPExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
legendecas
reviewed
Feb 23, 2022
Co-authored-by: legendecas <legendecas@gmail.com>
legendecas
approved these changes
Feb 24, 2022
vmarchaud
approved these changes
Feb 24, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Svetlana Brennan svetlana.svn@gmail.com
Which problem is this PR solving?
Partially Fixes #2706 (issue)
This PR is adding environment variables around compression to the http otlp exporter.
Short description of the changes
Updated
OTLPExporterNodeBase.tsto configure compression based on environment variables as well (not just through the config settings in code).Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: