-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(sdk): update earliest support node version #2860
docs(sdk): update earliest support node version #2860
Conversation
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should update the minimum version there: https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-sdk-trace-node/package.json#L33
Just in that package? Or in all the packages? |
All |
…kages Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
All packages (package.json engines node version) updated. |
Test failure is not related |
Signed-off-by: Svetlana Brennan svetlana.svn@gmail.com
Which problem is this PR solving?
Spans use
performance.timeOrigin
inperf_hooks
to createstartTime
andendTime
butperformance.timeOrigin
is set incorrectly before v8.12.0. Node introduced a fix for it that was backported tov8.12.0
.Fixes Issues # 2857 & 2834
Short description of the changes
Updated node support section in the sdk readme to say 8.12.0 as the earliest supported node version.
Type of change
Doc update
How Has This Been Tested?
NA
Checklist: