Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove -wip suffix in metrics packages #2872

Closed

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

These packages are already been marked as private, so they don't get published before they are ready to go.

Refs: #2871 (comment)

Type of change

  • New feature (non-breaking change which adds functionality)

Not really a new feature. This is breaking but we have not published these packages yet so I just marking it as new-feature as it is kinda significant.

Checklist:

  • Followed the style guidelines of this project

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #2872 (2635b51) into main (7870e95) will increase coverage by 1.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2872      +/-   ##
==========================================
+ Coverage   93.13%   94.48%   +1.34%     
==========================================
  Files         153       81      -72     
  Lines        5229     2447    -2782     
  Branches     1119      556     -563     
==========================================
- Hits         4870     2312    -2558     
+ Misses        359      135     -224     
Impacted Files Coverage Δ
...entelemetry-instrumentation-grpc/src/grpc/index.ts
...atform/node/instrumentationNodeModuleDefinition.ts
...ackages/opentelemetry-api-metrics/src/NoopMeter.ts
...telemetry-sdk-metrics-base/src/aggregator/index.ts
...ry-sdk-metrics-base/src/view/InstrumentSelector.ts
...s/exporter-trace-otlp-http/src/OTLPExporterBase.ts
...ckages/opentelemetry-sdk-metrics-base/src/utils.ts
...metry-sdk-metrics-base/src/InstrumentDescriptor.ts
...ry-sdk-metrics-base/src/state/SyncMetricStorage.ts
...entelemetry-sdk-metrics-base/src/aggregator/Sum.ts
... and 79 more

@legendecas
Copy link
Member Author

legendecas commented Mar 29, 2022

Well, not all packages that depends on @opentelemetry/sdk-metrics-base has been updated to the latest API definition.

Works left to do:

  • @opentelemetry/sdk-node
  • @opentelemetry/otlp-transformer
  • @opentelemetry/exporter-metrics-otlp-grpc
  • @opentelemetry/exporter-metrics-otlp-http
  • @opentelemetry/exporter-metrics-otlp-proto

@legendecas
Copy link
Member Author

This has done in #2871

@legendecas legendecas closed this Apr 8, 2022
@legendecas legendecas deleted the metrics-ff/packages branch April 8, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant