Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update OpenTelemetry deps in all experimental packages #2874

Closed
wants to merge 2 commits into from

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 30, 2022

This will hopefully solve some of the versioning headaches people are having.

@dyladan dyladan requested a review from a team March 30, 2022 15:22
@dyladan dyladan changed the title chore: update API in all experimental packages chore: update OpenTelemetry deps in all experimental packages Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #2874 (76f479d) into main (7870e95) will increase coverage by 1.34%.
The diff coverage is n/a.

❗ Current head 76f479d differs from pull request most recent head 90897f9. Consider uploading reports for the commit 90897f9 to get more accurate results

@@            Coverage Diff             @@
##             main    #2874      +/-   ##
==========================================
+ Coverage   93.13%   94.48%   +1.34%     
==========================================
  Files         153       81      -72     
  Lines        5229     2447    -2782     
  Branches     1119      556     -563     
==========================================
- Hits         4870     2312    -2558     
+ Misses        359      135     -224     
Impacted Files Coverage Δ
packages/opentelemetry-sdk-node/src/sdk.ts
...elemetry-instrumentation-grpc/src/grpc-js/index.ts
...-metrics-base/examples/metrics/metrics/observer.js
...emetry-instrumentation-xml-http-request/src/xhr.ts
...metry-instrumentation-grpc/src/grpc/clientUtils.ts
...sdk-metrics-base/src/view/RegistrationConflicts.ts
...entelemetry-instrumentation/src/instrumentation.ts
...y-sdk-metrics-base/src/view/AttributesProcessor.ts
...y-sdk-metrics-base/src/state/AsyncMetricStorage.ts
...sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
... and 79 more

@Flarna
Copy link
Member

Flarna commented Mar 30, 2022

Precondition for all these 1.1 updates is to get rid of the wip packages as they pull 1.0.x in.

@dyladan
Copy link
Member Author

dyladan commented Mar 30, 2022

The OTLP exporter update is being blocked by this dependency issue. The -wip package change is being blocked by the OTLP exporter update. This dependency issue is blocked by the -wip packages.

@Flarna
Copy link
Member

Flarna commented Mar 30, 2022

I guess a one PR to rule them all is needed.

@pichlermarc
Copy link
Member

I guess a one PR to rule them all is needed.

Unfortunately yes. We agreed in the SIG Meeting yesterday to do it in #2871.

@legendecas
Copy link
Member

Is this PR still valid after #2871 merged?

@dyladan
Copy link
Member Author

dyladan commented Apr 8, 2022

Is this PR still valid after #2871 merged?

Nope

@dyladan dyladan closed this Apr 8, 2022
@dyladan dyladan deleted the api-experimental branch April 8, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants