Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify changelog entry format #2889

Merged
merged 4 commits into from
Apr 7, 2022

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Refs: #2881 (comment)

Short description of the changes

Simplify the changelog entry format, so that it can be easier for people to manually fill in the entry.

Type of change

  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #2889 (b0e685a) into main (9890767) will decrease coverage by 0.81%.
The diff coverage is n/a.

❗ Current head b0e685a differs from pull request most recent head 32e92e7. Consider uploading reports for the commit 32e92e7 to get more accurate results

@@            Coverage Diff             @@
##             main    #2889      +/-   ##
==========================================
- Coverage   93.42%   92.61%   -0.82%     
==========================================
  Files         162       66      -96     
  Lines        5564     1976    -3588     
  Branches     1175      432     -743     
==========================================
- Hits         5198     1830    -3368     
+ Misses        366      146     -220     
Impacted Files Coverage Δ
...ckages/opentelemetry-sdk-trace-web/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
...ckages/opentelemetry-sdk-metrics-base/src/Meter.ts
...sdk-metrics-base/src/exemplar/ExemplarReservoir.ts
... and 94 more

@dyladan
Copy link
Member

dyladan commented Apr 6, 2022

@pichlermarc
Copy link
Member

Just realized that there's also the experimental/CHANGELOG.md file that needs to be updated. 🙂

pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Apr 7, 2022
@legendecas
Copy link
Member Author

@pichlermarc updated experimental/CHANGELOG.md :D

@dyladan
Copy link
Member

dyladan commented Apr 7, 2022

Seems fine. I'd merge it but the merge rules need another green check

@vmarchaud vmarchaud merged commit eac583e into open-telemetry:main Apr 7, 2022
@legendecas legendecas deleted the changelog branch April 15, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants