Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup API dependencies #2904

Merged
merged 4 commits into from
Apr 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import {
DataPoint,
Histogram,
} from '@opentelemetry/sdk-metrics-base';
import { MetricAttributes } from '@opentelemetry/api-metrics';
import type { MetricAttributes } from '@opentelemetry/api-metrics';
import { hrTimeToMilliseconds } from '@opentelemetry/core';

type PrometheusDataTypeLiteral =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
"peerDependencies": {
"@opentelemetry/api": "^1.0.0"
},
"todo": "Move API metrics to peer dependencies. While it is using an unpublished name, lerna doesn't properly link it if it is in peer dependencies",
"dependencies": {
"@opentelemetry/api-metrics": "0.27.0",
"@opentelemetry/core": "1.1.1",
Expand Down
10 changes: 5 additions & 5 deletions experimental/packages/opentelemetry-sdk-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,21 @@
},
"dependencies": {
"@opentelemetry/api-metrics": "0.27.0",
"@opentelemetry/core": "~1.1.1",
"@opentelemetry/core": "1.1.1",
"@opentelemetry/instrumentation": "0.27.0",
"@opentelemetry/resource-detector-aws": "~1.0.0",
"@opentelemetry/resource-detector-gcp": "~0.26.0",
"@opentelemetry/resources": "~1.1.1",
"@opentelemetry/resources": "1.1.1",
"@opentelemetry/sdk-metrics-base": "0.27.0",
"@opentelemetry/sdk-trace-base": "~1.1.1",
"@opentelemetry/sdk-trace-node": "~1.1.1"
"@opentelemetry/sdk-trace-base": "1.1.1",
"@opentelemetry/sdk-trace-node": "1.1.1"
},
"peerDependencies": {
"@opentelemetry/api": ">=1.0.0 <1.2.0"
},
"devDependencies": {
"@opentelemetry/api": ">=1.0.0 <1.2.0",
"@opentelemetry/context-async-hooks": "1.1.0",
"@opentelemetry/context-async-hooks": "1.1.1",
"@types/mocha": "8.2.3",
"@types/node": "14.17.33",
"@types/semver": "7.3.9",
Expand Down
5 changes: 2 additions & 3 deletions experimental/packages/otlp-transformer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,10 @@
"README.md"
],
"peerDependencies": {
"@opentelemetry/api": ">=1.0.0 <1.2.0",
"@opentelemetry/api-metrics": "~0.27.0"
"@opentelemetry/api": ">=1.0.0 <1.2.0"
},
"devDependencies": {
"@opentelemetry/api": ">=1.0.0 <1.2.0",
"@opentelemetry/api-metrics": "~0.27.0",
"@types/mocha": "8.2.3",
"@types/webpack-env": "1.16.3",
"codecov": "3.8.3",
Expand All @@ -71,6 +69,7 @@
"webpack": "4.46.0"
},
"dependencies": {
"@opentelemetry/api-metrics": "0.27.0",
blumamir marked this conversation as resolved.
Show resolved Hide resolved
"@opentelemetry/core": "1.1.1",
"@opentelemetry/resources": "1.1.1",
"@opentelemetry/sdk-metrics-base": "0.27.0",
Expand Down