fix(resources): extend ResourceAttributes interface to comply with spec #2924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be multiple ways to address this fix. I choose to use the interfaces from
@opentelemetry/api
but am open to other suggestions.Which problem is this PR solving?
Fixes #2907
The current interface of
ResourceAttributes
supports only a subset of what is defined in the spec.An array of primitive values are allowed in spec but are missing in the interface declaration in
@opentelemetry/resources
Short description of the changes
Use the same type from
@opentelemetry/api
.We should have used
Attributes
interface but since it's introduced in1.1.0
I choose theSpanAttributes
interface which will allow the SDK to work correctly with versions 1.0.x of the api.This change only broader the definition of the
ResourceAttributes
interface so it is not expected to break anything.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This is only change in typescript interface. Tested via CI run of current build / test / lint actions.
Checklist: