-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk-metrics-base): misbehaving aggregation temporality selector tolerance #2958
fix(sdk-metrics-base): misbehaving aggregation temporality selector tolerance #2958
Conversation
c916dcf
to
301e77b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2958 +/- ##
=======================================
Coverage 92.53% 92.53%
=======================================
Files 183 183
Lines 5958 5959 +1
Branches 1266 1266
=======================================
+ Hits 5513 5514 +1
Misses 445 445
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely glanced over this section when you initially mentioned the issue, thanks! 👍
Thanks for moving the changelog entry to the correct section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🙂
# Conflicts: # experimental/CHANGELOG.md
Which problem is this PR solving?
When the AggregationTemporalitySelector returns different AggregationTemporality for the same instrument type, the collection result can be very misleading and incorrect.
Short description of the changes
Type of change
How Has This Been Tested?
Checklist: