Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo on example link #3083

Merged
merged 1 commit into from
Jul 11, 2022
Merged

typo on example link #3083

merged 1 commit into from
Jul 11, 2022

Conversation

nfer
Copy link
Contributor

@nfer nfer commented Jul 11, 2022

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Short description of the changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@nfer nfer requested a review from a team July 11, 2022 08:39
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nfer / name: Nfer Zhuang (ebaac0b)

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! You'll have to sign the CLA before your PR can be accepted.

@nfer
Copy link
Contributor Author

nfer commented Jul 11, 2022

Thank you for your contribution! You'll have to sign the CLA before your PR can be accepted.

done.

@dyladan dyladan added Skip Changelog document Documentation-related labels Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #3083 (1e61e43) into main (b4707e4) will decrease coverage by 0.41%.
The diff coverage is n/a.

❗ Current head 1e61e43 differs from pull request most recent head ebaac0b. Consider uploading reports for the commit ebaac0b to get more accurate results

@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
- Coverage   93.08%   92.66%   -0.42%     
==========================================
  Files         188      173      -15     
  Lines        6261     5523     -738     
  Branches     1323     1175     -148     
==========================================
- Hits         5828     5118     -710     
+ Misses        433      405      -28     
Impacted Files Coverage Δ
packages/opentelemetry-resources/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...kages/opentelemetry-sdk-trace-base/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 53.33% <0.00%> (-46.67%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 95.45% <0.00%> (-4.55%) ⬇️
...ckages/opentelemetry-sdk-trace-web/karma.worker.js
...-sdk-trace-web/src/enums/PerformanceTimingNames.ts
packages/opentelemetry-sdk-trace-web/src/utils.ts
...-instrumentation-fetch/src/enums/AttributeNames.ts
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...telemetry-sdk-trace-web/src/StackContextManager.ts
... and 9 more

@dyladan dyladan merged commit 747c404 into open-telemetry:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants