Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update https example #3152

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Aug 8, 2022

Which problem is this PR solving?

Versions on the https example were outdated. The example server needed to be run as root, as it was using port 443. This PR

  • changes the port used to 8443 so it can be used with non-root users
  • also adds npm scripts to easily start Zipkin and Jaeger via docker and docker-compose.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual testing with new version of packages.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@pichlermarc pichlermarc force-pushed the chore/update-https-example branch from e147036 to 551510b Compare August 8, 2022 14:26
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #3152 (59b210d) into main (d995b80) will decrease coverage by 1.08%.
The diff coverage is n/a.

❗ Current head 59b210d differs from pull request most recent head 9669686. Consider uploading reports for the commit 9669686 to get more accurate results

@@            Coverage Diff             @@
##             main    #3152      +/-   ##
==========================================
- Coverage   93.23%   92.15%   -1.09%     
==========================================
  Files         196       87     -109     
  Lines        6414     2497    -3917     
  Branches     1350      547     -803     
==========================================
- Hits         5980     2301    -3679     
+ Misses        434      196     -238     
Impacted Files Coverage Δ
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...perimental/packages/otlp-exporter-base/src/util.ts 79.41% <0.00%> (-17.65%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
...kages/otlp-exporter-base/src/platform/node/util.ts
...ental/packages/otlp-grpc-exporter-base/src/util.ts
... and 107 more

@pichlermarc pichlermarc marked this pull request as ready for review August 8, 2022 15:40
@pichlermarc pichlermarc requested a review from a team August 8, 2022 15:40
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that there weren't really code changes required beyond the port

examples/https/package.json Outdated Show resolved Hide resolved
@dyladan dyladan merged commit 7b3eab6 into open-telemetry:main Aug 9, 2022
@dyladan dyladan deleted the chore/update-https-example branch August 9, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants