-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update https
example
#3152
chore: update https
example
#3152
Conversation
e147036
to
551510b
Compare
Codecov Report
@@ Coverage Diff @@
## main #3152 +/- ##
==========================================
- Coverage 93.23% 92.15% -1.09%
==========================================
Files 196 87 -109
Lines 6414 2497 -3917
Branches 1350 547 -803
==========================================
- Hits 5980 2301 -3679
+ Misses 434 196 -238
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that there weren't really code changes required beyond the port
Which problem is this PR solving?
Versions on the
https
example were outdated. The example server needed to be run as root, as it was using port443
. This PR8443
so it can be used with non-root usersnpm
scripts to easily start Zipkin and Jaeger via docker and docker-compose.Type of change
How Has This Been Tested?
Checklist: