Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-metrics): remove accidental export of the SDK Meter class #3243

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Looks like I missed the export of the SDKs Meter during the SDK clean up in #3197. This PR removes the export for Meter as the API's Meter interface is supposed to be used instead.

Related #3158

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Existing tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #3243 (52b8436) into main (5818129) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3243      +/-   ##
==========================================
+ Coverage   93.28%   93.30%   +0.01%     
==========================================
  Files         202      202              
  Lines        6599     6599              
  Branches     1384     1384              
==========================================
+ Hits         6156     6157       +1     
+ Misses        443      442       -1     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@pichlermarc pichlermarc marked this pull request as ready for review September 9, 2022 09:56
@pichlermarc pichlermarc requested a review from a team September 9, 2022 09:56
@dyladan dyladan merged commit be24d69 into open-telemetry:main Sep 12, 2022
@dyladan dyladan deleted the chore/remove-accidental-meter-export branch September 12, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants