Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove got temporarily #3347

Merged
merged 1 commit into from
Oct 19, 2022
+9 −6
Merged

Remove got temporarily #3347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ All notable changes to experimental packages in this project will be documented

### :house: (Internal)

* ci(instrumentation-http): remove got devDependency
[#3347](https://github.com/open-telemetry/opentelemetry-js/issues/3347) @dyladan

## 0.33.0

### :boom: Breaking Change
Expand Down
2 changes: 0 additions & 2 deletions experimental/packages/opentelemetry-instrumentation-http/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"@opentelemetry/context-async-hooks": "1.7.0",
"@opentelemetry/sdk-trace-base": "1.7.0",
"@opentelemetry/sdk-trace-node": "1.7.0",
"@types/got": "9.6.12",
"@types/mocha": "10.0.0",
"@types/node": "18.6.5",
"@types/request-promise-native": "1.0.18",
Expand All @@ -58,7 +57,6 @@
"@types/superagent": "4.1.13",
"axios": "0.24.0",
"codecov": "3.8.3",
"got": "9.6.0",
"mocha": "10.0.0",
"nock": "13.0.11",
"nyc": "15.1.0",
Expand Down
5 changes: 3 additions & 2 deletions ...imental/packages/opentelemetry-instrumentation-http/test/functionals/http-package.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ instrumentation.disable();
import * as http from 'http';
import * as request from 'request-promise-native';
import * as superagent from 'superagent';
import * as got from 'got';
// Temporarily removed. See https://github.com/open-telemetry/opentelemetry-js/issues/3344
// import * as got from 'got';
import * as nock from 'nock';
import axios, { AxiosResponse } from 'axios';

Expand Down Expand Up @@ -80,7 +81,7 @@ describe('Packages', () => {
[
{ name: 'axios', httpPackage: axios }, //keep first
{ name: 'superagent', httpPackage: superagent },
{ name: 'got', httpPackage: { get: (url: string) => got(url) } },
// { name: 'got', httpPackage: { get: (url: string) => got(url) } },
{
name: 'request',
httpPackage: { get: (url: string) => request(url) },
Expand Down
5 changes: 3 additions & 2 deletions ...mental/packages/opentelemetry-instrumentation-http/test/functionals/https-package.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ instrumentation.disable();
import * as http from 'http';
import * as request from 'request-promise-native';
import * as superagent from 'superagent';
import * as got from 'got';
// Temporarily removed. See https://github.com/open-telemetry/opentelemetry-js/issues/3344
// import * as got from 'got';
import * as nock from 'nock';
import axios, { AxiosResponse } from 'axios';

Expand Down Expand Up @@ -80,7 +81,7 @@ describe('Packages', () => {
[
{ name: 'axios', httpPackage: axios }, //keep first
{ name: 'superagent', httpPackage: superagent },
{ name: 'got', httpPackage: { get: (url: string) => got(url) } },
// { name: 'got', httpPackage: { get: (url: string) => got(url) } },
{
name: 'request',
httpPackage: { get: (url: string) => request(url) },
Expand Down