Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc request and response metadata #3386

Merged
merged 29 commits into from
Nov 23, 2022

Conversation

samimusallam
Copy link
Member

@samimusallam samimusallam commented Nov 7, 2022

Fixes #3358

Short description of the changes

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

I assert span results of a call to a unary method which contains custom metadata in both the request and response.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@samimusallam samimusallam requested a review from a team November 7, 2022 09:03
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #3386 (5b5441f) into main (897c136) will increase coverage by 0.03%.
The diff coverage is 97.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3386      +/-   ##
==========================================
+ Coverage   93.28%   93.31%   +0.03%     
==========================================
  Files         247      247              
  Lines        7352     7387      +35     
  Branches     1512     1518       +6     
==========================================
+ Hits         6858     6893      +35     
  Misses        494      494              
Impacted Files Coverage Δ
...es/opentelemetry-instrumentation-grpc/src/utils.ts 93.75% <90.90%> (-0.99%) ⬇️
...ry-instrumentation-grpc/src/grpc-js/clientUtils.ts 92.68% <100.00%> (+0.18%) ⬆️
...elemetry-instrumentation-grpc/src/grpc-js/index.ts 92.03% <100.00%> (+0.77%) ⬆️
...metry-instrumentation-grpc/src/grpc/clientUtils.ts 88.73% <100.00%> (+0.49%) ⬆️
...entelemetry-instrumentation-grpc/src/grpc/index.ts 93.79% <100.00%> (+0.52%) ⬆️
...-trace-base/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@samimusallam
Copy link
Member Author

Please let me know if I added the changes to the correct changelog as I see there's another one in opentelemetry-js/experimental :)

@vmarchaud
Copy link
Member

Please let me know if I added the changes to the correct changelog as I see there's another one in opentelemetry-js/experimental :)

You shoud move the entry to experimental/changelog.md since the package you modified is in experimental

@samimusallam
Copy link
Member Author

Please let me know if I added the changes to the correct changelog as I see there's another one in opentelemetry-js/experimental :)

You shoud move the entry to experimental/changelog.md since the package you modified is in experimental

Moved

@vmarchaud vmarchaud requested a review from a team November 14, 2022 10:00
@vmarchaud
Copy link
Member

cc @open-telemetry/javascript-approvers if someone have some time to review this :)

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement gRPC request and response metadata
4 participants