-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc request and response metadata #3386
Add grpc request and response metadata #3386
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3386 +/- ##
==========================================
+ Coverage 93.28% 93.31% +0.03%
==========================================
Files 247 247
Lines 7352 7387 +35
Branches 1512 1518 +6
==========================================
+ Hits 6858 6893 +35
Misses 494 494
|
experimental/packages/opentelemetry-instrumentation-grpc/src/grpc-js/index.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-grpc/test/helper.ts
Outdated
Show resolved
Hide resolved
Please let me know if I added the changes to the correct changelog as I see there's another one in opentelemetry-js/experimental :) |
You shoud move the entry to |
Moved |
cc @open-telemetry/javascript-approvers if someone have some time to review this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
experimental/packages/opentelemetry-instrumentation-grpc/src/grpc-js/clientUtils.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-grpc/src/utils.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-grpc/src/utils.ts
Outdated
Show resolved
Hide resolved
experimental/packages/opentelemetry-instrumentation-grpc/src/grpc-js/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % one nit
Fixes #3358
Short description of the changes
Type of change
How Has This Been Tested?
I assert span results of a call to a unary method which contains custom metadata in both the request and response.
Checklist: