Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release API 1.3.0 #3399

Merged
merged 4 commits into from
Nov 9, 2022
Merged

chore: release API 1.3.0 #3399

merged 4 commits into from
Nov 9, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 9, 2022

1.3.0

  • feat(api): merge api-metrics into api #3374 @legendecas
  • Optionally suppress warning about logger being overwritten (#3366)

@dyladan dyladan requested a review from a team November 9, 2022 15:04
@dyladan
Copy link
Member Author

dyladan commented Nov 9, 2022

This package needs to be released in order to unblock the main release PR. Because of lerna's lack of proper peerDependency handling, when the API version was bumped all the packages which peer depend on the unreleased version broke.

The failing tests are in the SDK because lerna fails to link the API to the SDK once the version is bumped. Once the API is released, the main release CI should pass.

@dyladan dyladan closed this Nov 9, 2022
@dyladan dyladan reopened this Nov 9, 2022
@dyladan dyladan marked this pull request as draft November 9, 2022 15:12
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #3399 (9037d35) into main (baf0fee) will decrease coverage by 1.14%.
The diff coverage is n/a.

❗ Current head 9037d35 differs from pull request most recent head fba8c1b. Consider uploading reports for the commit fba8c1b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3399      +/-   ##
==========================================
- Coverage   93.77%   92.63%   -1.15%     
==========================================
  Files          45      132      +87     
  Lines         643     3136    +2493     
  Branches      102      654     +552     
==========================================
+ Hits          603     2905    +2302     
- Misses         40      231     +191     
Impacted Files Coverage Δ
api/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
api/src/baggage/utils.ts 100.00% <0.00%> (ø)
...es/opentelemetry-core/src/propagation/composite.ts 100.00% <0.00%> (ø)
experimental/packages/api-logs/src/NoopLogger.ts 100.00% <0.00%> (ø)
packages/opentelemetry-resources/karma.worker.js 100.00% <0.00%> (ø)
...ckages/opentelemetry-sdk-trace-base/src/Sampler.ts 100.00% <0.00%> (ø)
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (ø)
...trace-base/src/sampler/TraceIdRatioBasedSampler.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation/src/instrumentation.ts 69.23% <0.00%> (ø)
packages/opentelemetry-core/src/utils/callback.ts 100.00% <0.00%> (ø)
... and 81 more

@dyladan dyladan marked this pull request as ready for review November 9, 2022 16:01
@dyladan
Copy link
Member Author

dyladan commented Nov 9, 2022

This CI pass is a false positive. The tests that were failing just didn't run this time. EasyCLA is the only one that ran. In any case I'm going to merge this because the tests that didn't run are expected to fail anyway.

@dyladan dyladan merged commit 27c4f76 into open-telemetry:main Nov 9, 2022
@dyladan dyladan deleted the api-release branch November 9, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants