Updated Node SDK example in README #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkuba
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3684 +/- ##
==========================================
+ Coverage 93.71% 93.73% +0.01%
==========================================
Files 277 277
Lines 8454 8454
Branches 1761 1761
==========================================
+ Hits 7923 7924 +1
+ Misses 531 530 -1 |
martinkuba
force-pushed
the
sdk-start-example
branch
from
4d2c36c
to
9e8279f
Compare
pichlermarc
approved these changes
Mar 17, 2023
Flarna
approved these changes
Mar 17, 2023
dyladan
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The start() method in the NodeSDK class has been recently updated to be synchronous (in #3460) - it no longer returns a promise. This is a minor update to the example in the corresponding README.