Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): exporter should be metricExporter #3688

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

hongbo-miao
Copy link
Contributor

@hongbo-miao hongbo-miao commented Mar 18, 2023

Which problem is this PR solving?

Just a small fix in the code in the readme. Based on the context, it should be metricExporter instead of not existing exporter. 😃

Short description of the changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@hongbo-miao hongbo-miao requested a review from a team March 18, 2023 06:57
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #3688 (56abc02) into main (25bb985) will not change coverage.
The diff coverage is n/a.

❗ Current head 56abc02 differs from pull request most recent head 321475b. Consider uploading reports for the commit 321475b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3688   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files         277      277           
  Lines        8445     8445           
  Branches     1753     1753           
=======================================
  Hits         7913     7913           
  Misses        532      532           

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants