fix(deps): update dependency require-in-the-middle to v7.1.0 for types and named export

[trentm]

Which problem is this PR solving?

This updates the 'require-in-the-middle' dep to one that includes typescript types and that
has a named export for the Hook function. It switches to using that named export.

Fixes: #3701

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• cd experimental/packages/opentelemetry-instrumentation; npm install; npm test

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[trentm]

Note for reviewers: This points to the proposed elastic/require-in-the-middle#67 to move TypeScript types to the require-in-the-middle module. Do those look reasonable?

[kirrg001]

Yes makes sense. It might be better though to create a new pull request for the types replacement.

[dyladan]

Using git to pull dependencies can result in significant slowdowns in many cases. Is there some reason you don't want to include them with the main package?

[kirrg001]

Using git to pull dependencies can result

I think the intention was not to merge this. Only to see if it works and to see if we agree with this change.

[trentm]

@dyladan The intention was not the merge this, but to allow for feedback on the index.d.ts file I was adding to require-in-the-middle at elastic/require-in-the-middle#67 before merging that, doing an RITM release, and then updating this PR to an actual RITM release version.

[trentm]

It might be better though to create a new pull request for the types replacement.

I can do that tomorrow. It'll then be one update to fix #3655 and a separate one for #3701

[trentm]

I've moved the fix for the first issue to #3743. Once that is in, I'll get a RITM 7.1.0 release with types and finish preparing this PR.

[Flarna]

In the other PR you use ^7.0.1 therefore 7.1.0 will be automatically used once released.
Will this result in problems/type conflicts and potentially broken builds?

[trentm]

@Flarna I don't think it will cause a problem. I've now released require-in-the-middle@7.1.0 -- which includes types. It still supports the default Hook export for usage. I guess what I don't know is whether TypeScript will prefer the local require-in-the-middle.d.ts over the types in the require-in-the-middle dep when resolving

opentelemetry-js/experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts

Line 27 in 61aae10

import * as RequireInTheMiddle from 'require-in-the-middle';

and similar.

I re-ran npm install in "experimental/packages/opentelemetry-instrumentation" in a git clone of the main branch to get the new release:

% npm ls require-in-the-middle
@opentelemetry/instrumentation@0.38.0 /Users/trentm/src/opentelemetry-js/experimental/packages/opentelemetry-instrumentation
└── require-in-the-middle@7.1.0

% git branch
* main
  v1.10

and npm run compile, npm test, and npm run lint are passing for me.

[dyladan]

I believe the types are actually merged "intelligently" when a module is declared twice

[codecov]

Codecov Report

Merging #3727 (91fdca2) into main (2f1e316) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 91fdca2 differs from pull request most recent head 4123476. Consider uploading reports for the commit 4123476 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3727      +/-   ##
==========================================
- Coverage   93.21%   93.20%   -0.01%     
==========================================
  Files         296      296              
  Lines        8999     8998       -1     
  Branches     1853     1853              
==========================================
- Hits         8388     8387       -1     
  Misses        611      611              

Impacted Files	Coverage Δ
...n/src/platform/node/RequireInTheMiddleSingleton.ts	90.00% <100.00%> (ø)
...strumentation/src/platform/node/instrumentation.ts	89.47% <100.00%> (-0.11%)	⬇️

[trentm]

@kirrg001 Are you appropriate to review this? Or perhaps @dyladan's review is sufficient to merge this. Another user recently asked on the motivating issue when this might get merged.

[trentm]

Thanks, all!