-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otlp-grpc-exporters): Add support for Unix domain socket endpoints. #3853
Conversation
95a1b2d
to
e4aaa25
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3853 +/- ##
=======================================
Coverage 92.88% 92.88%
=======================================
Files 297 297
Lines 8836 8838 +2
Branches 1814 1815 +1
=======================================
+ Hits 8207 8209 +2
Misses 629 629
|
e4aaa25
to
a0e209b
Compare
51ba19d
to
9aa3643
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM % one nits.
experimental/packages/exporter-trace-otlp-grpc/test/OTLPTraceExporter.test.ts
Outdated
Show resolved
Hide resolved
…ts. (open-telemetry#3853) * feat(otlp-grpc-exporter-base): add support for unix domain socket * test(otlp-grpc-exporter): add tests * chore(docs): update docs and changelog * fix: skip UDS tests on windows * Update CHANGELOG.md * fix: add protocol to http test urls * fix: update tests --------- Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com> Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
Short description of the changes
Currently the OTLP gRPC exporters only support http endpoints. This PR adds support for UDS endpoints.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: