Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-metrics): Update default Histogram's boundary to match OTEL's spec #3893

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

chigia001
Copy link
Contributor

Which problem is this PR solving?

Default HistogramAggergation's Boundary bucket is not matching OTEL's spec
Current bucket value: [0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000]
Expected bucket value: [0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000]

Fixes #3669

Short description of the changes

Update the default Boundary's bucket value to the correct version + update the unit test to match this new bucket value.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test with npm run test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been updated
  • Documentation has been updated

@chigia001 chigia001 requested a review from a team June 13, 2023 09:27
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #3893 (e05f31b) into main (95a5e0c) will not change coverage.
The diff coverage is n/a.

❗ Current head e05f31b differs from pull request most recent head 41158c5. Consider uploading reports for the commit 41158c5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3893   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files         297      297           
  Lines        8836     8836           
  Branches     1814     1814           
=======================================
  Hits         8207     8207           
  Misses        629      629           
Impacted Files Coverage Δ
packages/sdk-metrics/src/view/Aggregation.ts 93.82% <ø> (ø)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂
Only needs an entry in CHANGELOG.md and a few reformats to make the linter happy then this should be good to go 🙂

… spec

Signed-off-by: Chi Ma <chigia001@gmail.com>
@chigia001 chigia001 changed the title chore(sdk-metrics): update default Histogram's boundary to match OTEL's spec fix(sdk-metrics): update default Histogram's boundary to match OTEL's spec Jun 13, 2023
@chigia001
Copy link
Contributor Author

@pichlermarc I added the record in CHANGELOG.md and fix the lint issue.

@chigia001 chigia001 requested a review from pichlermarc June 13, 2023 12:22
@chigia001 chigia001 changed the title fix(sdk-metrics): update default Histogram's boundary to match OTEL's spec fix(sdk-metrics): Update default Histogram's boundary to match OTEL's spec Jun 13, 2023
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙂

@pichlermarc pichlermarc merged commit 5a1cd99 into open-telemetry:main Jun 13, 2023
@chigia001 chigia001 deleted the fix-3669 branch June 13, 2023 14:45
Nico385412 pushed a commit to Nico385412/opentelemetry-js that referenced this pull request Jun 14, 2023
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit histogram boundaries do not match the otel spec
4 participants