-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk-metrics): Update default Histogram's boundary to match OTEL's spec #3893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3893 +/- ##
=======================================
Coverage 92.88% 92.88%
=======================================
Files 297 297
Lines 8836 8836
Branches 1814 1814
=======================================
Hits 8207 8207
Misses 629 629
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙂
Only needs an entry in CHANGELOG.md
and a few reformats to make the linter happy then this should be good to go 🙂
… spec Signed-off-by: Chi Ma <chigia001@gmail.com>
@pichlermarc I added the record in CHANGELOG.md and fix the lint issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 🙂
Which problem is this PR solving?
Default HistogramAggergation's Boundary bucket is not matching OTEL's spec
Current bucket value:
[0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000]
Expected bucket value:
[0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000]
Fixes #3669
Short description of the changes
Update the default Boundary's bucket value to the correct version + update the unit test to match this new bucket value.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
npm run test
Checklist: