Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example-opencensus-shim): avoid OpenCensus auto instrumentations #3951

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

llc1123
Copy link
Contributor

@llc1123 llc1123 commented Jun 26, 2023

Which problem is this PR solving?

Currently the opencensus-shim example imports @opencensus/nodejs which also imports @opencensus/instrumentation-all and grpc and causes build fails on many platforms.

Short description of the changes

Changed @opencensus/nodejs to @opencensus/nodejs-base which does not include instrumentations.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project

@llc1123 llc1123 requested a review from a team June 26, 2023 08:25
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3951 (b42680d) into main (a30952c) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b42680d differs from pull request most recent head 1bc0aa3. Consider uploading reports for the commit 1bc0aa3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3951      +/-   ##
==========================================
+ Coverage   92.91%   92.92%   +0.01%     
==========================================
  Files         297      297              
  Lines        8838     8838              
  Branches     1815     1815              
==========================================
+ Hits         8212     8213       +1     
+ Misses        626      625       -1     

see 1 file with indirect coverage changes

@haddasbronfman haddasbronfman merged commit 15ede47 into open-telemetry:main Jun 26, 2023
@aabmass
Copy link
Member

aabmass commented Aug 16, 2023

@llc1123

Currently the opencensus-shim example imports @opencensus/nodejs which also imports @opencensus/instrumentation-all and grpc and causes build fails on many platforms.

How is this causing build failures if it is just an example? The code should not run as part of any build. This PR broke the example, following the instructions it no longer runs.

aabmass added a commit to aabmass/opentelemetry-js that referenced this pull request Aug 16, 2023
aabmass added a commit to aabmass/opentelemetry-js that referenced this pull request Aug 16, 2023
@aabmass
Copy link
Member

aabmass commented Aug 16, 2023

Opened a PR to revert. Let's discuss there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants