Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semconv to 1.21.0 #4009

Closed
wants to merge 2 commits into from
Closed

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jul 19, 2023

Opening as a draft as there are quite a few breaking changes. There are a couple ways we can go about this:

  1. Bump to 2.0. Probably want to combine with some structure updates for ongoing experimental updates without bumping major version every time.
  2. Manually add back the removed/renamed properties with @deprecated comments

Breaking changes by specification version

1.20.0

1.19.0

1.17.0

  • Refactor messaging attributes and per-message attributes in batching scenarios.
    (Refactor messaging attributes and specify per-message attributes opentelemetry-specification#2957).
    BREAKING: renames
    • messaging.consumer_id to messaging.consumer.id
    • messaging.destination to messaging.destination.name
    • messaging.temp_destination to messaging.destination.temporary
    • messaging.destination_kind to messaging.destination.kind
    • messaging.message_id to messaging.message.id
    • messaging.protocol to net.app.protocol.name
    • messaging.protocol_version to net.app.protocol.version
    • messaging.conversation_id to messaging.message.conversation_id
    • messaging.message_payload_size_bytes to messaging.message.payload_size_bytes
    • messaging.message_payload_compressed_size_bytes to messaging.message.payload_compressed_size_bytes
    • messaging.rabbitmq.routing_key to messaging.rabbitmq.destination.routing_key
    • messaging.kafka.message_key to messaging.kafka.message.key
    • messaging.kafka.consumer_group to messaging.kafka.consumer.group
    • messaging.kafka.partition to messaging.kafka.destination.partition
    • messaging.kafka.tombstone to messaging.kafka.message.tombstone
    • messaging.rocketmq.message_type to messaging.rocketmq.message.type
    • messaging.rocketmq.message_tag to messaging.rocketmq.message.tag
    • messaging.rocketmq.message_keys to messaging.rocketmq.message.keys
    • Removed messaging.url
    • Renamed send operation to publish
    • Split destination and source namespaces and clarify per-message attributes in batching scenarios

Full list of removed keys

  • DB_CASSANDRA_KEYSPACE
  • DB_HBASE_NAMESPACE
  • FAAS_EXECUTION
  • NET_PEER_IP
  • NET_HOST_IP
  • NET_HOST_CONNECTION_TYPE
  • NET_HOST_CONNECTION_SUBTYPE
  • NET_HOST_CARRIER_NAME
  • NET_HOST_CARRIER_MCC
  • NET_HOST_CARRIER_MNC
  • NET_HOST_CARRIER_ICC
  • HTTP_HOST
  • HTTP_FLAVOR
  • HTTP_USER_AGENT
  • HTTP_REQUEST_CONTENT_LENGTH_UNCOMPRESSED
  • HTTP_RESPONSE_CONTENT_LENGTH_UNCOMPRESSED
  • HTTP_SERVER_NAME
  • HTTP_CLIENT_IP
  • MESSAGING_DESTINATION_KIND
  • MESSAGING_TEMP_DESTINATION
  • MESSAGING_PROTOCOL
  • MESSAGING_PROTOCOL_VERSION
  • MESSAGING_URL
  • MESSAGING_CONVERSATION_ID
  • MESSAGING_CONSUMER_ID
  • MESSAGING_RABBITMQ_ROUTING_KEY
  • MESSAGING_KAFKA_CLIENT_ID
  • MESSAGING_KAFKA_PARTITION
  • MESSAGING_KAFKA_TOMBSTONE
  • NetTransportValues.IP_TCP
  • NetTransportValues.IP_UDP
  • NetTransportValues.IP
  • NetTransportValues.UNIX
  • NetTransportValues.INPROC
  • NetTransportValues.OTHER
  • NetHostConnectionTypeValues
  • NetHostConnectionSubtypeValues
  • HttpFlavorValues
  • MessagingDestinationKindValues

@dyladan
Copy link
Member Author

dyladan commented Jul 19, 2023

Tests are failing because of the breaking changes used by the instrumentations.

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 18, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This PR was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant