-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(README): clarify browser support #4037
Merged
pichlermarc
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:docs/mention-client-sig-in-readme
Aug 7, 2023
Merged
docs(README): clarify browser support #4037
pichlermarc
merged 6 commits into
open-telemetry:main
from
dynatrace-oss-contrib:docs/mention-client-sig-in-readme
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4037 +/- ##
==========================================
+ Coverage 92.36% 92.71% +0.34%
==========================================
Files 321 287 -34
Lines 9264 8143 -1121
Branches 1968 1689 -279
==========================================
- Hits 8557 7550 -1007
+ Misses 707 593 -114 |
legendecas
approved these changes
Aug 4, 2023
chalin
reviewed
Aug 4, 2023
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
chalin
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
dyladan
approved these changes
Aug 7, 2023
This was referenced Nov 27, 2023
[Snyk] Security upgrade @opentelemetry/sdk-node from 0.40.0 to 0.41.2
sumodgeorge/opentelemetry-js#7
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently, browser support of the packages in this repo is not considered production-ready, we should set expectations in the
README.md
accordingly.Fixes #4035
See also open-telemetry/opentelemetry.io#3125
Short description of the changes
Adds a not based on open-telemetry/opentelemetry.io#3125 to the README under
Browser Support
. Removes the checkmark forBrowser Support
in the supported runtimesType of change