feat(api): add attributes argument to recordException API

[dvoytenko]

Which problem is this PR solving?

Adds the optional attributes argument to the recordException API.

Fixes #4070

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• packages/opentelemetry-sdk-trace-base/test/common/Span.test.ts

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: dvoytenko / name: Dima Voytenko (6d528aa, 02fc890, f70a9df, 8f71f2c)
• ✅ login: pichlermarc / name: Marc Pichler (96df3fa)

[codecov]

Codecov Report

Merging #4071 (d0c01a8) into main (c84637f) will decrease coverage by 0.78%.
The diff coverage is 0.00%.

❗ Current head d0c01a8 differs from pull request most recent head 96df3fa. Consider uploading reports for the commit 96df3fa to get more accurate results

@@            Coverage Diff             @@
##             main    #4071      +/-   ##
==========================================
- Coverage   90.52%   89.74%   -0.78%     
==========================================
  Files         159      140      -19     
  Lines        3757     3014     -743     
  Branches      835      653     -182     
==========================================
- Hits         3401     2705     -696     
+ Misses        356      309      -47     

Files Changed	Coverage
api/src/trace/NonRecordingSpan.ts	0.00%

[legendecas]

For reference, open-telemetry/opentelemetry-js-api#97 is the last attempt to implement the feature. @dyladan would you mind confirming if the condition is changed since then (about the comment open-telemetry/opentelemetry-js-api#97 (comment))?

[dvoytenko]

For reference, open-telemetry/opentelemetry-js-api#97 is the last attempt to implement the feature. @dyladan would you mind confirming if the condition is changed since then (about the comment open-telemetry/opentelemetry-js-api#97 (comment))?

That change indeed looks very similar. Not sure why it didn't fully go in. It looks like the addEvent API has been appropriately modified, but not recordException.

[dyladan]

@dyladan would you mind confirming if the condition is changed since then (about the comment open-telemetry/opentelemetry-js-api#97 (comment))?

We've had several feature releases of the API since then. There is no need to backport fixes to previous minor versions. The backport requirement is only for major versions according to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/versioning-and-stability.md#api-support

[dvoytenko]

I updated the changelog to unblock the changelog workflow.

[hectorhdzg]

LGTM

[dvoytenko]

@legendecas @dyladan thank you for your reviews! How do I merge this PR now?

[dvoytenko]

@MSNev I update the APIs as requested. RE:

Also need to add the param to the documentation

Could you point me to where I need to make this change?

[legendecas]

Also need to add the param to the documentation

Could you point me to where I need to make this change?

I believe you have done this well in the latest commit.

[legendecas]

Still LGTM.