-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk-metrics): do not report empty scopes and metrics #4135
Merged
pichlermarc
merged 15 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/4130
Sep 28, 2023
Merged
fix(sdk-metrics): do not report empty scopes and metrics #4135
pichlermarc
merged 15 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/4130
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4135 +/- ##
==========================================
+ Coverage 92.28% 92.30% +0.02%
==========================================
Files 329 329
Lines 9370 9382 +12
Branches 1991 1996 +5
==========================================
+ Hits 8647 8660 +13
+ Misses 723 722 -1
|
legendecas
approved these changes
Sep 13, 2023
svetlanabrennan
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR changes the behavior of the SDK to not report empty scopes (currently exported when a Meter is created, but never used), or empty metrics (instruments that were created, but never observed).
Fixes #4130
Partially addresses #4096 (now, never observed instruments are not exported).
Type of change
How Has This Been Tested?