fix(exporter-zipkin): round timestamp to nearest integer in zipkin annotations #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeEmerim
force-pushed
the
fix/round-timestamp-in-zipkin-annotations
branch
from
411c40d
to
70d6c4d
Compare
FelipeEmerim
force-pushed
the
fix/round-timestamp-in-zipkin-annotations
branch
from
70d6c4d
to
bba7814
Compare
pichlermarc
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Thank you for fixing this 🙂
Relevant specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md#unit-of-time
Codecov Report
@@ Coverage Diff @@
## main #4167 +/- ##
==========================================
- Coverage 92.19% 92.10% -0.10%
==========================================
Files 324 328 +4
Lines 9228 9235 +7
Branches 1935 1955 +20
==========================================
- Hits 8508 8506 -2
- Misses 720 729 +9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Exporter-zipkin was not rounding the timestamp field on annotations which causes 400 errors when traces include annotations.
Fixes #4165
Short description of the changes
Round the timestamp field to the nearest integer on every annotation.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: