-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added performance benchmarking doc #4169
Conversation
878af26
to
7ed1fc6
Compare
Codecov Report
@@ Coverage Diff @@
## main #4169 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 331 331
Lines 9465 9465
Branches 1997 1997
=======================================
Hits 8732 8732
Misses 733 733 |
7ed1fc6
to
0f66d0d
Compare
0f66d0d
to
6c9a840
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment about the test:bench
script, otherwise looks good 🙂
Co-authored-by: Tyler Benson <tylerbenson@gmail.com>
The semantic conventions docs have been removed from the specification repo. I have updated the links here, but let me know if you prefer that to be in a separate PR. @pichlermarc |
Ah, I think having it in this PR is fine. Thanks for fixing it 🙂 |
Which problem is this PR solving?
Part of #4171
Short description of the changes
This PR adds a doc with instructions on how to add new benchmark tests.