-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IsRemote field to SpanContext, set by propagators #451
Conversation
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
+ Coverage 94.94% 95.23% +0.29%
==========================================
Files 123 125 +2
Lines 5815 6279 +464
Branches 491 516 +25
==========================================
+ Hits 5521 5980 +459
- Misses 294 299 +5
|
Thank you so much for the contribution and welcome to OpenTelemetry 👍 |
Should we also use this flag ( opentelemetry-js/packages/opentelemetry-exporter-zipkin/src/types.ts Lines 74 to 78 in b58965c
/cc @hekike |
We have to set the flag when extracing from BinaryTraceContext - used by gRPC plugin, Could you please update the PR and include that? |
@@ -35,6 +35,10 @@ export interface SpanContext { | |||
* lowercase hex characters corresponding to 64 bits. | |||
*/ | |||
spanId: string; | |||
/** | |||
* Indicates if the SpanContext was propagated from a remote parent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you specify the default? I assume the default is false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not set to false anywhere explicitly so it'll be undefined
by default. Should I just change the comment or add a isRemote: false
to all new SpanContexts?
Makes it more obvious when the flag changes and what the default value is.
LGTM, merging now. Let's consider above stuff for separate PR/Issue. |
Which problem is this PR solving?
Short description of the changes
isRemote
toSpanContext