Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(span): rename span recording flag #454

Merged
merged 3 commits into from
Oct 22, 2019
Merged

fix(span): rename span recording flag #454

merged 3 commits into from
Oct 22, 2019

Conversation

xiao-lix
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Rename span flag IsRecordingEvents -> IsRecording

@codecov-io
Copy link

codecov-io commented Oct 22, 2019 •
edited
Loading

Codecov Report

Merging #454 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files         123      123           
  Lines        6104     6104           
  Branches      507      506    -1     
=======================================
  Hits         5822     5822           
  Misses        282      282
Impacted Files Coverage Δ
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 100% <ø> (ø) ⬆️
packages/opentelemetry-tracing/src/Span.ts 100% <100%> (ø) ⬆️
...ackages/opentelemetry-node/test/NodeTracer.test.ts 100% <100%> (ø) ⬆️
packages/opentelemetry-core/src/trace/NoopSpan.ts 100% <100%> (ø) ⬆️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 100% <100%> (ø) ⬆️
packages/opentelemetry-tracing/src/BasicTracer.ts 100% <100%> (ø) ⬆️
packages/opentelemetry-tracing/test/Span.test.ts 100% <100%> (ø) ⬆️
...ges/opentelemetry-tracing/test/BasicTracer.test.ts 100% <100%> (ø) ⬆️
...try-tracing/test/export/BatchSpanProcessor.test.ts 100% <100%> (ø) ⬆️

@xiao-lix
Copy link
Contributor Author

CLA signed.

mayurkale22
mayurkale22 approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one minor comment.

@xiao-lix @mayurkale22
Update packages/opentelemetry-types/src/trace/SpanOptions.ts
58e3879 
Co-Authored-By: Mayur Kale <mayurkale@google.com>
@OlivierAlbertini OlivierAlbertini added the enhancement New feature or request label Oct 22, 2019
OlivierAlbertini
OlivierAlbertini approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run gts fix to pass the build. LGTM

@mayurkale22 mayurkale22 merged commit 972faa2 into open-telemetry:master Oct 22, 2019
@xiao-lix xiao-lix deleted the xiao/fix-naming branch October 22, 2019 23:35
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@dyladan
chore: make aws generator public (open-telemetry#454)
5ecccc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@markwolff markwolff markwolff approved these changes

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@bg451 bg451 Awaiting requested review from bg451

@danielkhan danielkhan Awaiting requested review from danielkhan

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@rochdev rochdev Awaiting requested review from rochdev

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix: IsRecordingEvents -> IsRecording
5 participants
@xiao-lix @codecov-io @OlivierAlbertini @markwolff @mayurkale22