-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename EventEmitter to EventLogger in the Events API #4568
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4568 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 328 328
Lines 9494 9494
Branches 2040 2040
=======================================
Hits 8815 8815
Misses 679 679
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinkuba renaming looks good, but looks like there's still a lot of places where the term event emitter
is used in the context of the api-events
package.
(re-running failed test, seems to be unrelated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 🙂
…4568) * renamed EventEmitter to EventLogger * updated changelog * renamed remaining references to emitter * lint
Which problem is this PR solving?
As discussed in open-telemetry/opentelemetry-specification#3869, the decision has been made in the Specification SIG meeting on 3/2/24 to rename EventEmitter to EventLogger in the API.
Technically this is a breaking change. But the API is in very early experimental stage without a default SDK implementation.
Type of change