feat(opentelemetry-instrumentation-xhr): optionally ignore network events #4571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
PR #3028 added a
ignoreNetworkEvents
boolean to theexperimental/opentelemetry-instrumentation-fetch
package. This PR adds the same behaviour + flag to theexperimental/opentelemetry-instrumentation-xml-http-request
package.Quoting from that PR
Short description of the changes
This PR adds an optional boolean flag
ignoreNetworkEvents
to the XMLHttpRequest instrumentation. When set to true network events are not added to the span.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Running npm run test:browser will run the newly added test as part of the suite:
Checklist: