Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(resources): implements service.instance.id #4608

Merged
merged 12 commits into from
Apr 15, 2024
Merged

feat(resources): implements service.instance.id #4608

merged 12 commits into from
Apr 15, 2024

Commits on Apr 11, 2024

  1. feat(node-sdk): implements service.instance.id 

    Implements `service.instance.id`

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
    @maryliag
    maryliag committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e38e25a View commit details
    Browse the repository at this point in the history

  2. implement service instance id by default with env var 

    use an experimental environment variable to set the default value of `service.instance.id` as default
    @maryliag
    maryliag committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    b729f0b View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md 

    Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
    @maryliag @pichlermarc
    maryliag and pichlermarc committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6b00564 View commit details
    Browse the repository at this point in the history

  4. create separate add experimental for browser and node 

    create a function to add experimental default values (currently only service instance id, but others can be added in the future),
with the value being set on the node case, but not on the browser case.

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
    @maryliag
    maryliag committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7976713 View commit details
    Browse the repository at this point in the history

  5. use resource detector for service instance id 

    use a resource detector for service instance id
    @maryliag
    maryliag committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0f96158 View commit details
    Browse the repository at this point in the history

  6. remove references to env variables

    @maryliag
    maryliag committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    032c660 View commit details
    Browse the repository at this point in the history

  7. remove Detector and use DetectorSync 

    remove the Detector and use the DetectorSync instead. Also mark things as experimental.

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
    @maryliag
    maryliag committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f6a0694 View commit details
    Browse the repository at this point in the history

  8. Update packages/opentelemetry-resources/src/platform/node/ServiceInst… 

    …anceIDDetectorSync.ts

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
    @maryliag @pichlermarc
    maryliag and pichlermarc committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    bc7478a View commit details
    Browse the repository at this point in the history

  9. rename ServiceInstanceIDDetector to ServiceInstanceIDDetectorSync

    @maryliag
    maryliag committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    78c31e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. change ID to Id

    @maryliag
    maryliag committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a6a779f View commit details
    Browse the repository at this point in the history

  2. renaming something temp so git will pick up the name change 

    it was not picking up the case change on previous commit
    @maryliag
    maryliag committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    118e713 View commit details
    Browse the repository at this point in the history

  3. update to final name using Id

    @maryliag
    maryliag committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    54baf54 View commit details
    Browse the repository at this point in the history