-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add addExporter to Meter #482
Merged
mayurkale22
merged 6 commits into
open-telemetry:master
from
dynatrace-oss-contrib:add-exporter
Nov 6, 2019
Merged
feat: add addExporter to Meter #482
mayurkale22
merged 6 commits into
open-telemetry:master
from
dynatrace-oss-contrib:add-exporter
Nov 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
danielkhan,
markwolff,
mayurkale22,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
November 4, 2019 19:45
danielkhan
approved these changes
Nov 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 94.98% 94.98% -0.01%
==========================================
Files 136 136
Lines 6482 6478 -4
Branches 567 567
==========================================
- Hits 6157 6153 -4
Misses 325 325
|
bg451
approved these changes
Nov 4, 2019
mayurkale22
reviewed
Nov 5, 2019
mayurkale22
approved these changes
Nov 5, 2019
The only failing test is in edit: it also only failed on node 11. Is there a flaky test? edit again: now always failing? |
6 tasks
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
addExporter(exporter: MetricExporter)
toMeter