chore: drop ts-mocha for mocha and ts-node #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
added
dependencies
david-luna
approved these changes
Jul 2, 2024
trentm
approved these changes
Jul 2, 2024
Yes, we should remove that too, good catch 👍 223fc40 |
dyladan
approved these changes
Jul 3, 2024
10 tasks
trentm
added a commit
to trentm/opentelemetry-js-contrib
that referenced
this pull request
Aug 10, 2024
tedious@18 adds its own .d.ts files. Compiling with them requires TypeScript v5, and either target:'es2022' for 'AggregateError' or using skipLibCheck:true in tsconfig.json. This change limits the update to TypeScript v5 to just while testing tedious@18 via test-all-versions' support for 'peerDependencies'. THis also drops ts-mocha in favour of 'mocha --require ts-node/register' as was done on opentelemetry-js.git in open-telemetry/opentelemetry-js#4840 Closes: open-telemetry#2266
trentm
added a commit
to open-telemetry/opentelemetry-js-contrib
that referenced
this pull request
Aug 19, 2024
tedious@18 adds its own .d.ts files. Compiling with them requires TypeScript v5, and either target:'es2022' for 'AggregateError' or using skipLibCheck:true in tsconfig.json. This change limits the update to TypeScript v5 to just while testing tedious@18 via test-all-versions' support for 'peerDependencies'. THis also drops ts-mocha in favour of 'mocha --require ts-node/register' as was done on opentelemetry-js.git in open-telemetry/opentelemetry-js#4840 Closes: #2266
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
* chore: drop ts-mocha for mocha and ts-node * fixup! chore: drop ts-mocha for mocha and ts-node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it says on the tin. I've had this kicking around for a while but never got to actually open the PR.