Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove "export *" in favor of explicit named exports #4880

Merged
merged 15 commits into from
Aug 9, 2024
Merged

refactor: remove "export *" in favor of explicit named exports #4880

merged 15 commits into from
Aug 9, 2024

Commits on Jul 25, 2024

  1. add no export-star rule to api's eslint

    @robbkidd
    robbkidd committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0ba7e65 View commit details
    Browse the repository at this point in the history

  2. no more export-star, only specifics

    @robbkidd
    robbkidd committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    919854d View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. declare the rule at the root 

    Remove special case eslint rule from API.
    @robbkidd
    robbkidd committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e1aab56 View commit details
    Browse the repository at this point in the history

  2. add baggageUtils check to integration tests 

    Sanity check before the rewrite of export * as nameSpace to explicit
exports under a nameSpace.

Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
    @robbkidd @JamieDanielson
    robbkidd and JamieDanielson committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    dd73e23 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. make implicit re-exports explicit 

    Mostly scripted. Thanks, Trent!

Re-exports under namespaces and re-exports from another package were
done by hand.

We have intentionally not tackled NodeSDK yet. Awaiting feedback on
this approach so far before updating that package.

OTLP exporters omitted from this pass because work is in progress on them
in other branches.

Co-authored-by: Trent Mick <trentm@gmail.com>
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
    @robbkidd @trentm @JamieDanielson
    3 people committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    45accb1 View commit details
    Browse the repository at this point in the history

  2. dial eslint down to warn on exports being worked separately 

    Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
    @robbkidd @JamieDanielson
    robbkidd and JamieDanielson committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    6b46bd8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into api.no-export-star

    @robbkidd
    robbkidd authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    8a4b892 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. disable warning about 'export *' in semconv 

    Updated the comment to remove the TODO because there is no expected
followup. SemConv will use `export *` of the generated constants.
    @robbkidd
    robbkidd committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0fe69ad View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. move assertions about core to separate test file 

    api-entries is about api; core-entries is about core. Both are still
under ./integration-tests/api, but maybe that's OK?
    @robbkidd
    robbkidd committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f0124ea View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into api.no-export-star

    @robbkidd
    robbkidd committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    fbe20c5 View commit details
    Browse the repository at this point in the history

  3. remove ts-node from integration test deps 

    Maybe we don't need ts-node here after all?
    @robbkidd
    robbkidd committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9c0b671 View commit details
    Browse the repository at this point in the history

  4. update changelogs

    @robbkidd
    robbkidd committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    fbe156f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. omit listing pkgs that only had doc comments added 

    Also, put my name on it.
    @robbkidd
    robbkidd committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d0a2b85 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Update CHANGELOG.md 

    Co-authored-by: Trent Mick <trentm@gmail.com>
    @pichlermarc @trentm
    pichlermarc and trentm authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    afcbcc4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into api.no-export-star

    @pichlermarc
    pichlermarc authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    a34c7b7 View commit details
    Browse the repository at this point in the history